Conversation
…atibility Replace complex DataSetInterpolator/ITPWrapper structs stored as MTK parameter defaults with plain arrays as @discretes. These mutable structs contained BSpline objects, file handles, locks, and async tasks that cannot transfer to GPU. Key changes: - New array-based interp_unsafe using fractional 1-based indices (GPU-compatible) - @discretes with typed AbstractArray annotations for data arrays - Scalar @discretes for time grid parameters (tstart, tstep) - @constants for spatial grid parameters and extrapolation type - create_interp_equation returns (eq, discretes, constants, interp_info) - build_interp_expr helper for z_params pattern (geosfp, wrf, NCEP-NCAR) - create_updater_sys_event uses ImperativeAffect with ctx for DSI objects - promote_shape fixes for interp_unsafe and ifelse (SymbolicUtils bug workaround) - Updated all data source constructors (geosfp, nei, wrf, NCEP-NCAR) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataSetInterpolator/ITPWrapperstructs stored as MTK parameter defaults with plain arrays as@discretes, moving complex objects into system event callback contextinterp_unsafeusing fractional 1-based indices — pure arithmetic + array indexing, zero allocations, GPU-compatiblecreate_interp_equationAPI returning(eq, discretes, constants, interp_info)promote_shapebug whereifelsereturnstrue(Bool) instead of the shapecreate_updater_sys_eventuses ImperativeAffect withctxforDataSetInterpolatorobjects (kept out of parameter buffer)Status
canonicalize_eq!subtraction error inTearingStateduring coupled systemmtkcompileneeds investigation)Test plan
Pkg.test())🤖 Generated with Claude Code