cam6_4_072: Fix broken RRTMGP GPU tests#1260
Merged
nusbaume merged 3 commits intoESCOMP:cam_developmentfrom Feb 28, 2025
Merged
cam6_4_072: Fix broken RRTMGP GPU tests#1260nusbaume merged 3 commits intoESCOMP:cam_developmentfrom
nusbaume merged 3 commits intoESCOMP:cam_developmentfrom
Conversation
Collaborator
Author
|
fix #997 |
nusbaume
approved these changes
Feb 25, 2025
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Looks good to me! Just had one general question on the explicit passing of DDTs as well as the variables they contain.
cacraigucar
changed the title
nusbaume
force-pushed
the
fix_rrtmgp_gpu
branch
from
4fe456a to
a7294bf
Compare
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Apr 14, 2025
Merge pull request ESCOMP#1260 from sjsprecious/fix_rrtmgp_gpu cam6_4_072: Fix broken RRTMGP GPU tests ESCOMP commit: 17a0cbd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken RRTMGP GPU tests reported in #997 . The changes are borrowed from the EarthWorks code base (EarthWorksOrg#25, thanks to John and Supreeth).
I used the
cam6_4_064tag on Derecho and confirmed that running PUMAS+CLUBB+RRTMGP on the NVIDIA A100 GPU now passed the ensemble consistency test.The CPU tests should be BFB. I updated the GPU tests to enable the RRTMGP GPU code so the results were different from the existing baseline as expected.