[WIP] Add an embedding layer for the months#120
Open
gabrieltseng wants to merge 5 commits intomasterfrom
Open
Conversation
Contributor
|
@gabrieltseng is this still good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Yasser's comments, replaces the one hot encoding with an embedding.
Currently, the size of the embedding is fixed at 12, but if this works well this could become an additional argument.The size of the embedding is an additional argument - ifNoneis passed, the prediction month isn't passed to the model.Also, removes the EALSTM cell written using
nn.Modules, since the original one works fine with shap.