EVA-685 Integrate with variation-commons library#212
Merged
nitin-ebi merged 1 commit intoEBIvariation:integrate-variation-commonsfrom Jan 19, 2026
Merged
Conversation
nitin-ebi
force-pushed
the
integrate-variation-commons
branch
7 times, most recently
from
f6d39c3 to
a3a2ba2
Compare
nitin-ebi
force-pushed
the
integrate-variation-commons
branch
from
a3a2ba2 to
3fb36b9
Compare
tcezard
approved these changes
Jan 16, 2026
Contributor
apriltuesday
left a comment
apriltuesday
left a comment
There was a problem hiding this comment.
This is awesome, I'm so happy that we're finally doing this 💪
Should we merge to a feature branch until we've completed the integration and tested it more thoroughly? Just to be safe...
src/test/java/uk/ac/ebi/eva/test/configuration/MongoCollectionNameConfiguration.java
Show resolved
Hide resolved
Contributor
Author
Yes, I was planning to merge it into a feature as well. We Should complete the next set of changes and do the testing before merging into master. |
apriltuesday
approved these changes
Jan 19, 2026
nitin-ebi
merged commit 3d0c3fe
into
EBIvariation:integrate-variation-commons
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.