Skip to content

chore: .editorconfig + CI coverage gate + gitignore updates#84

Merged
DsThakurRawat merged 1 commit intomainfrom
chore/project-hygiene
Apr 20, 2026
Merged

chore: .editorconfig + CI coverage gate + gitignore updates#84
DsThakurRawat merged 1 commit intomainfrom
chore/project-hygiene

Conversation

@DsThakurRawat
Copy link
Copy Markdown
Owner

What

  1. .editorconfig: Consistent formatting rules
  2. .gitignore: Added log file patterns
  3. python-ci.yml: Added --cov-fail-under=70 coverage gate

Impact

No code changes. CI now enforces minimum 70% test coverage.

- .editorconfig: enforce 4-space Python, 2-space YAML/JS
- .gitignore: add uvicorn.log, dashboard_build*.log patterns
- python-ci.yml: add --cov-fail-under=70
@DsThakurRawat DsThakurRawat merged commit fba5a7a into main Apr 20, 2026
1 check passed
@DsThakurRawat DsThakurRawat deleted the chore/project-hygiene branch April 20, 2026 05:32
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@DsThakurRawat has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 23 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 23 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f8f05d15-429b-4fdb-9935-f1bb6e805f55

📥 Commits

Reviewing files that changed from the base of the PR and between e7404a0 and ce0d90c.

📒 Files selected for processing (3)
  • .editorconfig
  • .github/workflows/python-ci.yml
  • .gitignore
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/project-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an .editorconfig file to standardize formatting across the project and updates the .gitignore file to exclude various log files, temporary scripts, and generated directories. Feedback was provided regarding the .editorconfig to align the Python line length with existing project settings and to separate Rust and Go indentation rules. Additionally, a concern was raised about ignoring the entire docs/ directory in .gitignore, as it might inadvertently exclude documentation source files.

Comment thread .editorconfig
[*.py]
indent_style = space
indent_size = 4
max_line_length = 99
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The max_line_length of 99 for Python files conflicts with the project's configuration in pyproject.toml, which sets the limit to 88 (lines 48 and 232). Keeping these values synchronized ensures that the editor's visual guides align with the linting rules enforced in CI.

max_line_length = 88

Comment thread .editorconfig
Comment on lines +25 to +26
[*.{go,rs}]
indent_style = tab
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Rust (.rs) files should use 4 spaces for indentation according to the standard Rust style guide, while Go files use tabs. It is recommended to separate these into distinct blocks to avoid applying tab indentation to Rust code.

[*.go]
indent_style = tab

[*.rs]
indent_style = space
indent_size = 4

Comment thread .gitignore
claude/
output/
deliverables/
docs/
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Ignoring the entire docs/ directory may lead to documentation source files being excluded from the repository. If docs/ contains source material (e.g., Markdown or Sphinx source), consider ignoring only the specific build output directory (e.g., docs/_build/) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant