Auto-remove unreachable UDP clients on repeated send failures#138
Open
kevdotnet wants to merge 1 commit intoDroneBridge:masterfrom
Open
Auto-remove unreachable UDP clients on repeated send failures#138kevdotnet wants to merge 1 commit intoDroneBridge:masterfrom
kevdotnet wants to merge 1 commit intoDroneBridge:masterfrom
Conversation
Problem When a UDP client (e.g. a GCS laptop) disconnects from the Wi-Fi network without sending any further packets, the ESP32 has no way to detect the disconnect via the connectionless UDP protocol. Subsequent sendto() calls to the stale client return ENOMEM (errno 12), causing a flood of error log messages until the device is rebooted or the client reconnects. Fix Added a send_fail_count field to db_udp_client_t. Each consecutive send failure to a client increments the counter; a successful send resets it to zero. After 5 consecutive failures the client is removed from the UDP distribution list with a warning log, silencing the error spam and freeing the slot for new clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a UDP client (e.g. a GCS laptop) disconnects from the Wi-Fi network without sending any further packets, the ESP32 has no way to detect the disconnect via the connectionless UDP protocol. Subsequent sendto() calls to the stale client return ENOMEM (errno 12), causing a flood of error log messages until the device is rebooted or the client reconnects.
Fix
Added a send_fail_count field to db_udp_client_t. Each consecutive send failure to a client increments the counter; a successful send resets it to zero. After 5 consecutive failures the client is removed from the UDP distribution list with a warning log, silencing the error spam and freeing the slot for new clients.