Skip to content

Enable 'Select Network' settings panel#107

Open
benfinix wants to merge 1 commit intomainfrom
feature/settings-wifi
Open

Enable 'Select Network' settings panel#107
benfinix wants to merge 1 commit intomainfrom
feature/settings-wifi

Conversation

@benfinix
Copy link
Copy Markdown
Contributor

Draft PR ready for enabling network selection in the settings menu.

Have re-used the network selection view from the configuration process, and hidden some elements when we're not in recovery
image

Terminology also updated from 'wifi' to 'select network' as this is not exclusive to wifi networks
image

…owRecoveryOptions' that's used to only show some of the elements when in recovery mode (Settings menu item will not an SSH key to be set, or the configuration time warning to be shown). Updated label and description of settings item from 'wifi' to 'select network' as wired networks may also be available.
@DivineGod DivineGod force-pushed the feature/settings-wifi branch from 15c5c80 to 610e48e Compare July 18, 2025 09:24
@patowens
Copy link
Copy Markdown
Contributor

Given some time has passed, I've tested this afresh, I find the following:

  1. It doesn't have the currently set network shown by default. I reckon it should
  2. When submitting, it calls two APIs /network/set-pending, /system/bootstrap

I think the APIs involved should actually be
/network/set-pending
/network/connect

As /system/bootstrap returns a 403 because it cannot be called outside of recovery mode.

@patowens
Copy link
Copy Markdown
Contributor

The /network/list api does not indicate which interface is currently set. I recommend we update the api to include a isCurrentInterface (or similar) flag.

@elusiveshiba elusiveshiba self-assigned this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants