fix: thread-safety for static sets in Boavizta modules#148
Merged
jnioche merged 3 commits intoDigitalPebble:mainfrom Feb 13, 2026
Merged
fix: thread-safety for static sets in Boavizta modules#148jnioche merged 3 commits intoDigitalPebble:mainfrom
jnioche merged 3 commits intoDigitalPebble:mainfrom
Conversation
davide954
force-pushed
the
fix/boavizta-thread-safety
branch
from
e4b0827 to
88f1a2c
Compare
Makes the access to shared data structures thread-safe. Specifically, it replaces the `HashSet` with a `ConcurrentHashMap.newKeySet()` for storing unknown instance types, ensuring that multiple threads can safely update the set without causing race conditions or data corruption.
Member
|
thanks @davide954 |
jnioche
changed the title
Member
|
thanks @davide954 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to address the thread-safety discussion #146 regarding
unknownInstanceTypes.Todo
HashSetwithConcurrentHashMapinBoaviztAPI.javaHashSetwithConcurrentHashMapinBoaviztAPIstatic.javaThis ensures the module is safe for concurrent execution without significant performance overhead.
Description
Addresses the thread-safety concern regarding the static
unknownInstanceTypesfield, as discussed.Since Spark tasks run concurrently within the same Executor JVM, sharing a non-thread-safe
HashSetcan lead toConcurrentModificationExceptionor infinite loops during map resizing.