Conversation
|
Well, this PR kind of went a different direction. Might as well just go all the way (but pinky swear this isn't another RotatingLog v2 lol) The current Multi-lock support is added. This is in anticipation of writes involving multiple resources, e.g. "add archive to category" may be a candidate for this, but that's something for another day. Also, the order should be deterministic. Lock ownership with tokens is added. This means that even if a lock is acquired by a different worker, they still cannot release the lock as they don't "own" it. A sha strategy was chosen, but tbh we can probably get away with raw Optional TTL is added. This is for Shinobu, where I feel the job could take longer than 10s, especially with those category operations.. ( This The previous limitation with These changes should beat down these log assertion failures once and for all! Well of course, they would also make LRR more reliable and predictable to use... |
add_to_filemapis triggered on file events, which can frequently race against active file changes resulting in missing files during ID computation. If this happens, we don't really have an "error"-severity log.This is one of the main invalid integration test case failure reasons, so tightening this condition will get rid of some noise. Or we can keep the logs if a file doesn't exist and demote that case to warning.