Skip to content

Fix unit test breakage from smargon limit enforcement changes in dodal#1264

Merged
rtuck99 merged 1 commit intomainfrom
fix_unit_tests_for_smargon_limit_enforcement
Sep 11, 2025
Merged

Fix unit test breakage from smargon limit enforcement changes in dodal#1264
rtuck99 merged 1 commit intomainfrom
fix_unit_tests_for_smargon_limit_enforcement

Conversation

@rtuck99
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 commented Sep 11, 2025

Fixes further breakage to unit tests from

(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Unit tests pass

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (16bc12e) to head (3e8666b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         128      128           
  Lines        7925     7925           
=======================================
  Hits         7112     7112           
  Misses        813      813           
Components Coverage Δ
i24 SSX 75.60% <ø> (ø)
hyperion 97.72% <ø> (ø)
other 97.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 marked this pull request as ready for review September 11, 2025 09:31
@rtuck99 rtuck99 requested a review from a team as a code owner September 11, 2025 09:31
Copy link
Copy Markdown
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rtuck99 rtuck99 merged commit 6725bd6 into main Sep 11, 2025
25 checks passed
@rtuck99 rtuck99 deleted the fix_unit_tests_for_smargon_limit_enforcement branch September 11, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants