Skip to content

Fix unit tests following ophyd-async changes#1262

Merged
DominicOram merged 2 commits intomainfrom
fix_unit_tests_for_motor_limits
Sep 10, 2025
Merged

Fix unit tests following ophyd-async changes#1262
DominicOram merged 2 commits intomainfrom
fix_unit_tests_for_motor_limits

Conversation

@rtuck99
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 commented Sep 10, 2025

Fixes unit tests against the latest ophyd-async (v0.13.2) following

Link to dodal PR (if required): #N/A
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Unit tests pass

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@rtuck99 rtuck99 marked this pull request as ready for review September 10, 2025 16:20
@rtuck99 rtuck99 requested a review from a team as a code owner September 10, 2025 16:20
@rtuck99 rtuck99 marked this pull request as draft September 10, 2025 16:21
@rtuck99 rtuck99 marked this pull request as ready for review September 10, 2025 16:32
Copy link
Copy Markdown
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! Sorry, I should have checked this as part of looking at it all this morning.

@DominicOram DominicOram merged commit 16bc12e into main Sep 10, 2025
19 checks passed
@DominicOram DominicOram deleted the fix_unit_tests_for_motor_limits branch September 10, 2025 16:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (862375d) to head (c6ee7bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1262   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         128      128           
  Lines        7925     7925           
=======================================
  Hits         7112     7112           
  Misses        813      813           
Components Coverage Δ
i24 SSX 75.60% <ø> (ø)
hyperion 97.72% <ø> (ø)
other 97.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rtuck99 added a commit that referenced this pull request Sep 15, 2025
* Ensure motor limits are patched following ophyd-async changes

* Unpin dodal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants