Skip to content

Implement alerts for UDC complete, baton release and UDC start#1257

Merged
rtuck99 merged 4 commits intomainfrom
1180_alerts_for_udc_start_finish
Sep 11, 2025
Merged

Implement alerts for UDC complete, baton release and UDC start#1257
rtuck99 merged 4 commits intomainfrom
1180_alerts_for_udc_start_finish

Conversation

@rtuck99
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 commented Sep 9, 2025

Fixes the remaining alerts in

Link to dodal PR (if required): #N/A
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Hyperion will now raise an alert on the following events:

  • UDC Start (i.e. when Hyperion acquires the baton and begins processing instructions)
  • UDC Complete (i.e. when Hyperion receives an empty instruction list from Agamemnon, indicating there are no more instructions to process)
  • When Hyperion releases the baton. When Hyperion sends this alert it will indicate which user requested the baton from Hyperion, if any, in order to help distinguish between when Hyperion finishing naturally and Hyperion pausing due to a baton transfer.

Instructions to reviewer on how to test:

  1. Test pass
  2. When running in UDC mode, the above alerts are issued

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.75%. Comparing base (6725bd6) to head (7bbd2a4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
+ Coverage   89.74%   89.75%   +0.01%     
==========================================
  Files         128      128              
  Lines        7925     7933       +8     
==========================================
+ Hits         7112     7120       +8     
  Misses        813      813              
Components Coverage Δ
i24 SSX 75.60% <ø> (ø)
hyperion 97.73% <100.00%> (+<0.01%) ⬆️
other 97.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 marked this pull request as ready for review September 9, 2025 10:37
@rtuck99 rtuck99 requested a review from a team as a code owner September 9, 2025 10:37
@rtuck99 rtuck99 force-pushed the 1180_alerts_for_udc_start_finish branch from bc9dc65 to 2201e16 Compare September 9, 2025 10:37
Copy link
Copy Markdown
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Minor nit pick but otherwise fine



def _raise_udc_completed_alert(alert_service: AlertService):
alert_service.raise_alert(Subjects.UDC_COMPLETED, "Hyperion UDC has completed.", {})
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would be a bit more specific here, mention that the Agamemnon queue is empty or something

@rtuck99 rtuck99 force-pushed the 1180_alerts_for_udc_start_finish branch 2 times, most recently from 30c03f6 to 38e989e Compare September 11, 2025 09:00
@rtuck99 rtuck99 force-pushed the 1180_alerts_for_udc_start_finish branch from 38e989e to 7bbd2a4 Compare September 11, 2025 10:16
@rtuck99 rtuck99 merged commit 8a92887 into main Sep 11, 2025
24 checks passed
@rtuck99 rtuck99 deleted the 1180_alerts_for_udc_start_finish branch September 11, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants