Implement alerts for UDC complete, baton release and UDC start#1257
Merged
Implement alerts for UDC complete, baton release and UDC start#1257
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1257 +/- ##
==========================================
+ Coverage 89.74% 89.75% +0.01%
==========================================
Files 128 128
Lines 7925 7933 +8
==========================================
+ Hits 7112 7120 +8
Misses 813 813
🚀 New features to boost your workflow:
|
bc9dc65 to
2201e16
Compare
DominicOram
approved these changes
Sep 9, 2025
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
Great, thanks. Minor nit pick but otherwise fine
|
|
||
|
|
||
| def _raise_udc_completed_alert(alert_service: AlertService): | ||
| alert_service.raise_alert(Subjects.UDC_COMPLETED, "Hyperion UDC has completed.", {}) |
Contributor
There was a problem hiding this comment.
Nit: I would be a bit more specific here, mention that the Agamemnon queue is empty or something
30c03f6 to
38e989e
Compare
38e989e to
7bbd2a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining alerts in
Link to dodal PR (if required): #N/A
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Hyperion will now raise an alert on the following events:
Instructions to reviewer on how to test:
Checks for reviewer