Remove i24 references to Pilatus detector#1253
Conversation
|
Change of scope: Remove i24 references to Pilatus serial operations and tests Making these change addresses:
Note that same branch used, as it already contained bulk changes. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 89.75% 89.99% +0.24%
==========================================
Files 128 128
Lines 7933 7719 -214
==========================================
- Hits 7120 6947 -173
+ Misses 813 772 -41
🚀 New features to boost your workflow:
|
noemifrisina
left a comment
There was a problem hiding this comment.
Lgtm, thanks. Just one small change I think we should make...
Tbh, this is such a huge removal of code that we really need some beamline testing to be sure we caught all of the smaller pilatus bits.
|
As a side note - we should make a change in dodal to go with this one where the pilatus_metadata and pilatus_bc devices are removed from the i24 definition file, since they won't be able to connect anymore. |
Changes to be addressed in separate PRs
Addresses #1226
Change of scope: Remove i24 references to Pilatus serial operations and tests
Making these change addresses:
Note that same branch used, as it already contained bulk changes.
For reference: Original scope
Fixes #1252
Add detector stage limits and add DCM to Pilatus
Fix dcm references for Pilatus to pass tests
Defer Pilatus-specific tests while Pilatus detectors being removed from I24 plans
Instructions to reviewer on how to test:
Checks for reviewer