Skip to content

Remove i24 references to Pilatus detector#1253

Merged
phathaway merged 13 commits intomainfrom
1252_Add_stage_limit_checks
Sep 16, 2025
Merged

Remove i24 references to Pilatus detector#1253
phathaway merged 13 commits intomainfrom
1252_Add_stage_limit_checks

Conversation

@phathaway
Copy link
Copy Markdown
Contributor

@phathaway phathaway commented Sep 8, 2025

Addresses #1226

Change of scope: Remove i24 references to Pilatus serial operations and tests
Making these change addresses:

  • addresses previous scope changes to pilatus-related parameters
  • removal of limit checks superseded by dodal changes

Note that same branch used, as it already contained bulk changes.

For reference: Original scope
Fixes #1252
Add detector stage limits and add DCM to Pilatus
Fix dcm references for Pilatus to pass tests
Defer Pilatus-specific tests while Pilatus detectors being removed from I24 plans

Instructions to reviewer on how to test:

  1. Passes CI tests

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@phathaway phathaway self-assigned this Sep 9, 2025
Comment thread src/mx_bluesky/beamlines/i24/serial/setup_beamline/setup_beamline.py Outdated
@phathaway phathaway changed the title Add detector stage limits and add DCM to Pilatus Remove i24 references to Pilatus detector Sep 10, 2025
@phathaway
Copy link
Copy Markdown
Contributor Author

Change of scope: Remove i24 references to Pilatus serial operations and tests
Addresses #1226

Making these change addresses:

  • addresses previous scope changes to pilatus-related parameters
  • removal of limit checks superseded by dodal changes

Note that same branch used, as it already contained bulk changes.

@phathaway phathaway mentioned this pull request Sep 10, 2025
1 task
@phathaway phathaway marked this pull request as ready for review September 11, 2025 08:35
@phathaway phathaway requested a review from a team as a code owner September 11, 2025 08:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.99%. Comparing base (0dac399) to head (40cc788).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
+ Coverage   89.75%   89.99%   +0.24%     
==========================================
  Files         128      128              
  Lines        7933     7719     -214     
==========================================
- Hits         7120     6947     -173     
+ Misses        813      772      -41     
Components Coverage Δ
i24 SSX 75.18% <94.28%> (-0.42%) ⬇️
hyperion 97.73% <ø> (ø)
other 97.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks. Just one small change I think we should make...

Tbh, this is such a huge removal of code that we really need some beamline testing to be sure we caught all of the smaller pilatus bits.

@noemifrisina
Copy link
Copy Markdown
Contributor

As a side note - we should make a change in dodal to go with this one where the pilatus_metadata and pilatus_bc devices are removed from the i24 definition file, since they won't be able to connect anymore.

@noemifrisina noemifrisina dismissed their stale review September 16, 2025 09:53

Changes to be addressed in separate PRs

@phathaway phathaway merged commit 5eee6dc into main Sep 16, 2025
24 checks passed
@phathaway phathaway deleted the 1252_Add_stage_limit_checks branch September 16, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I24 serial: Add z-stage limit checks

3 participants