Skip to content

Conversation

@neon60
Copy link
Collaborator

@neon60 neon60 commented Oct 30, 2024

  • Add Raven filter to strip.py
  • Add Raven filter unit tests
  • Add Raven filter performance tests

@neon60 neon60 marked this pull request as ready for review November 9, 2024 23:23
@neon60 neon60 requested a review from namannimmo10 November 12, 2024 08:16
@dkazanc
Copy link
Collaborator

dkazanc commented Nov 12, 2024

thanks @neon60. I've also added you to the contributors list so you can create branches from httomolibgpu directly. In that case the CI of ours that run tests should work (I suspect that it is a reason for the current failure). I will test the method on a real data.

Copy link
Member

@namannimmo10 namannimmo10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you Istvan!

@dkazanc dkazanc changed the base branch from main to ravenfilter November 18, 2024 12:40
@dkazanc dkazanc merged commit d2f8363 into DiamondLightSource:ravenfilter Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants