Conversation
Co-authored-by: Joseph Ware <53935796+DiamondJoseph@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 98.24% 98.63% +0.38%
==========================================
Files 5 5
Lines 57 73 +16
==========================================
+ Hits 56 72 +16
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… into 66-implement-caching-on-get_configuration
olliesilvester
left a comment
There was a problem hiding this comment.
Thank you! Just a few minor comments, happy to discuss if you disagree/they don't make sense
olliesilvester
left a comment
There was a problem hiding this comment.
Thanks, I've made some more suggestions to try and keep the logic more simple
olliesilvester
left a comment
There was a problem hiding this comment.
The logic + tests looks great now, thanks. I have some opinionated requests for some of the comments, then I will approve
Co-authored-by: Joseph Ware <53935796+DiamondJoseph@users.noreply.github.com>
…on-get_configuration
…m:DiamondLightSource/daq-config-server into 66-implement-caching-on-get_configuration
olliesilvester
left a comment
There was a problem hiding this comment.
Thanks! I will wait to resolve that conversation with @DiamondJoseph before merging
Fixes #66