Merged
Conversation
olliesilvester
commented
Apr 28, 2025
| name: daqconfig | ||
| description: DAQ configuration server | ||
| name: helmchart | ||
| description: A Helm chart for Kubernetes |
Contributor
Author
There was a problem hiding this comment.
@DiamondJoseph I thought it might be easier to just leave it as the helm create template for now and do it properly in #69
Comment on lines
+9
to
+14
| image: | ||
| repository: nginx | ||
| # This sets the pull policy for images. | ||
| pullPolicy: IfNotPresent | ||
| # Overrides the image tag whose default is the chart appVersion. | ||
| tag: "" |
Contributor
There was a problem hiding this comment.
If this is the way you want to go right now, I would at least make this section correct and have the example ingress ready.
Co-authored-by: Joseph Ware <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 65.25% 65.25%
=======================================
Files 6 6
Lines 213 213
=======================================
Hits 139 139
Misses 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
helmchart/templates/ingress.yaml
Outdated
| @@ -0,0 +1,22 @@ | |||
| {{- if .Values.ingress.create -}} | |||
Contributor
There was a problem hiding this comment.
Is this taken from the bluapi ingress? It doesn't look like the default ingress from helm create
Co-authored-by: Joseph Ware <[email protected]>
DiamondJoseph
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64