Skip to content

Update to NodeJS v24#33379

Closed
dmlvr wants to merge 6 commits intoDevExpress:26_1from
dmlvr:26_1_fix_node_version
Closed

Update to NodeJS v24#33379
dmlvr wants to merge 6 commits intoDevExpress:26_1from
dmlvr:26_1_fix_node_version

Conversation

@dmlvr
Copy link
Copy Markdown
Contributor

@dmlvr dmlvr commented Apr 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 08:45
@dmlvr dmlvr requested a review from a team as a code owner April 23, 2026 08:45
@dmlvr dmlvr self-assigned this Apr 23, 2026
@dmlvr dmlvr added the 26_1 label Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the monorepo’s Node.js baseline to v24 by enforcing Node requirements in workspace manifests and aligning CI to use a single version source (.node-version).

Changes:

  • Add engines.node >=24 across packages/apps to declare the new minimum Node version.
  • Add .node-version (24.15.0) / update .tool-versions, and switch GitHub Actions workflows to node-version-file.
  • Enable engine-strict=true in .npmrc (root and packages/sbom) to enforce engine checks during installs.

Reviewed changes

Copilot reviewed 48 out of 48 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
packages/testcafe-models/package.json Add Node >=24 engine requirement.
packages/sbom/package.json Add Node >=24 engine requirement.
packages/sbom/.npmrc Enforce engine checks for sbom workspace.
packages/nx-infra-plugin/package.json Add Node >=24 engine requirement.
packages/eslint-migration-utils/package.json Add Node >=24 engine requirement.
packages/devextreme/package.json Add Node >=24 engine requirement.
packages/devextreme-vue/package.json Add Node >=24 engine requirement.
packages/devextreme-themebuilder/package.json Add Node >=24 engine requirement.
packages/devextreme-scss/package.json Add Node >=24 engine requirement.
packages/devextreme-react/package.json Add Node >=24 engine requirement.
packages/devextreme-monorepo-tools/package.json Add Node >=24 engine requirement.
packages/devextreme-metadata/package.json Add Node >=24 engine requirement.
packages/devextreme-dist/package.json Add Node >=24 engine requirement.
packages/devextreme-angular/package.json Add Node >=24 engine requirement.
package.json Add Node >=24 engine requirement for the workspace root.
e2e/wrappers/package.json Add Node >=24 engine requirement.
e2e/testcafe-devextreme/package.json Add Node >=24 engine requirement.
e2e/devextreme-bundler/package.json Add Node >=24 engine requirement.
e2e/compilation-cases/package.json Add Node >=24 engine requirement.
e2e/bundlers/package.json Add Node >=24 engine requirement.
apps/vue/package.json Add Node >=24 engine requirement.
apps/react/package.json Add Node >=24 engine requirement.
apps/react-storybook/package.json Add Node >=24 engine requirement.
apps/demos/package.json Add Node >=24 engine requirement.
apps/angular/package.json Add Node >=24 engine requirement.
.tool-versions Bump asdf Node version to 24.15.0.
.npmrc Enforce engine checks at repo root.
.node-version Add canonical Node version file (24.15.0) for CI/local tools.
.github/workflows/wrapper_tests_e2e.yml Switch CI Node selection to .node-version.
.github/workflows/wrapper_tests.yml Switch CI Node selection to .node-version.
.github/workflows/visual-tests-demos.yml Switch CI Node selection to .node-version.
.github/workflows/update_version.yml Switch CI Node selection to .node-version.
.github/workflows/ts_declarations.yml Switch CI Node selection to .node-version.
.github/workflows/themebuilder_tests.yml Switch CI Node selection to .node-version.
.github/workflows/testcafe_tests.yml Switch CI Node selection to .node-version.
.github/workflows/styles.yml Switch CI Node selection to .node-version.
.github/workflows/run-testcafe-on-gh-pages.yml Switch CI Node selection to .node-version.
.github/workflows/renovation.yml Switch CI Node selection to .node-version.
.github/workflows/qunit_tests.yml Switch CI Node selection to .node-version.
.github/workflows/publish-demos.yml Switch CI Node selection to .node-version.
.github/workflows/pr-storybook-deploy-manual.yml Switch CI Node selection to .node-version.
.github/workflows/playgrounds_tests.yml Switch CI Node selection to .node-version.
.github/workflows/packages_publishing.yml Switch CI Node selection to .node-version.
.github/workflows/lint.yml Switch CI Node selection to .node-version.
.github/workflows/demos_unit_tests.yml Switch CI Node selection to .node-version.
.github/workflows/default_workflow.yml Switch CI Node selection to .node-version.
.github/workflows/codeql.yml Switch CI Node selection to .node-version.
.github/workflows/build_all.yml Switch CI Node selection to .node-version (partial; see comments).

Comment thread packages/devextreme-angular/package.json Outdated
Comment thread packages/devextreme-themebuilder/package.json Outdated
Comment thread apps/angular/package.json Outdated
Comment thread apps/vue/package.json Outdated
Comment thread .github/workflows/build_all.yml
Comment thread package.json Outdated
Comment thread packages/nx-infra-plugin/package.json Outdated
Comment thread .node-version Outdated
Copilot AI review requested due to automatic review settings April 23, 2026 10:10
@dmlvr dmlvr force-pushed the 26_1_fix_node_version branch from 2e46a5b to fdf1d12 Compare April 23, 2026 10:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Comment thread .npmrc
Comment thread .node-version Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Copilot AI review requested due to automatic review settings April 24, 2026 10:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/run-testcafe-on-gh-pages.yml
Copilot AI review requested due to automatic review settings April 24, 2026 12:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Comment thread .github/actions/run-qunit-tests/action.yml
Comment thread packages/devextreme/package.json Outdated
Copilot AI review requested due to automatic review settings April 29, 2026 15:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.

Comment thread .github/actions/run-qunit-tests/action.yml
Comment thread .github/workflows/default_workflow.yml
Comment thread .npmrc Outdated
@dmlvr dmlvr force-pushed the 26_1_fix_node_version branch from 0956fe7 to 3b711a6 Compare May 7, 2026 11:12
@dmlvr dmlvr closed this May 7, 2026
@dmlvr dmlvr deleted the 26_1_fix_node_version branch May 7, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants