Skip to content

e2e: Move cursor before test #32787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marker-dao wants to merge 7 commits into
base: 26_1
Choose a base branch
from
+3 −1
Open

e2e: Move cursor before test #32787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be35554
TestCafe: Move cursor before test
Mar 4, 2026
5ac7b26
revert(minor)
Mar 4, 2026
b6822e5
chore()
Mar 4, 2026
6ebc311
feat(runners): Replace event call with testcafe click
Mar 4, 2026
23cc069
revert(minor)
Mar 4, 2026
0f70914
feat(runners): Remove click, Add hover html with big offsets
Mar 4, 2026
cc51ae8
fix(runners): Set offset 1
Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed apps/demos/testing/etalons/Chat-Customization (material.blue.light)_mask.png
View file
Open in desktop
Binary file not shown.
Binary file removed apps/demos/testing/etalons/Chat-MessageEditing (fluent.blue.light)_mask.png
View file
Open in desktop
Binary file not shown.
2 changes: 2 additions & 0 deletions apps/demos/utils/visual-tests/testcafe-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ async function main() {
}
window.getSelection()?.removeAllRanges();
}).with({ boundTestRun: t })();

await t.hover('html', { offsetX: 1, offsetY: 1 });
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a hard-coded hover offset (1,1). To improve readability/maintainability, consider using a named constant for the offset (or add a short comment for why this specific coordinate is chosen) so future changes don’t unintentionally reintroduce cursor-related flakiness.

Copilot uses AI. Check for mistakes.
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion e2e/testcafe-devextreme/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ async function main() {
window.getSelection()?.removeAllRanges();
}).with({ boundTestRun: t })();

await t.hover('html');
await t.hover('html', { offsetX: 1, offsetY: 1 });
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hover offset values (1,1) are magic numbers here. Consider introducing a small named constant (e.g., a MOUSE_RESET_OFFSET) or adding a brief inline comment explaining why these specific offsets are required (e.g., avoiding edge/scrollbar coordinates) to make the intent clearer and avoid accidental changes later.

Copilot uses AI. Check for mistakes.

const [width, height] = meta?.browserSize ?? DEFAULT_BROWSER_SIZE;
await t.resizeWindow(width, height);
Expand Down
Loading