Conversation
added 19 commits
November 17, 2025 17:31
…line up with the actual behavior
…ts in codePointsForGlyph()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更概要
src/errors.tsにてFontkitErrorクラスとそのサブクラスを導入。従来
Errorを throw していた箇所をすべてこれらで置換して、原因の種別を明示化logErrors()等をlogWarnings()に命名修正。有効化時は
console.error()ではなくconsole.warn()を呼ぶよう変更TTFFont#_getTable内のみで、その用途は実質ワーニングであるためその他
今回
errors.tsをTypeScript形式で追加したことに伴い、ビルド・テスト関連で下記を改善:mochaによるテスト時に使用。テスト対象に
*.tsが含まれても良いように