Skip to content

fix(weblog/python-flask): missing f in f-string #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eldolfin wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix(weblog/python-flask): missing f in f-string #6673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1fc522
fix(weblog/python-flask): missing f in f-string
Eldolfin Mar 31, 2026
e0c616f
Merge branch 'main' into oscarld/fix-python-flask-missing-f-string
Eldolfin Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/build/docker/python/flask/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def rasp_sqli(*args, **kwargs):
DB = sqlite3.connect(":memory:")
print(f"SELECT * FROM users WHERE id='{user_id}'")
cursor = DB.execute(f"SELECT * FROM users WHERE id='{user_id}'")
print("DB request with {len(list(cursor))} results")
print(f"DB request with {len(list(cursor))} results")
return f"DB request with {len(list(cursor))} results"
Comment on lines +439 to 440
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid exhausting SQL cursor before composing response

The new f-string log call iterates cursor once (len(list(cursor))) before the response is built, so in any case where the query succeeds and returns rows, the subsequent len(list(cursor)) in the return path will always be 0 because the cursor has already been consumed. This changes endpoint behavior from reporting actual row count to always reporting zero; compute the count once and reuse it for both log and response.

Useful? React with 👍 / 👎.

except Exception as e:
print(f"DB request failure: {e!r}", file=sys.stderr)
Expand Down
Loading