Auto-activate ruby easy wins for apm-sdk-capabilities#6659
Auto-activate ruby easy wins for apm-sdk-capabilities#6659dd-octo-sts[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 831783aabb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/parametric/test_dynamic_configuration.py::TestDynamicConfigSamplingRules::test_trace_sampling_rules_with_tags: bug (APMAPI-868) | ||
| tests/parametric/test_dynamic_configuration.py::TestDynamicConfigSamplingRules::test_remote_sampling_rules_retention: # TODO: a lower version might be supported | ||
| - declaration: bug (APMAPI-867) | ||
| component_version: <2.30.0 |
There was a problem hiding this comment.
Quote semver range values in manifest declarations
The new manifest blocks use unquoted values like component_version: <2.30.0 (for example here), but our manifest syntax rules require quoting values with special YAML characters (<, >, :, #). Leaving these unquoted can be interpreted inconsistently by YAML tooling and tends to break strict lint/format validation in CI; please wrap these ranges in quotes (e.g., '<2.30.0') for all newly added entries in this commit.
Useful? React with 👍 / 👎.
Automated activation of easy-win tests for
rubyowned byapm-sdk-capabilitiesView nightly workflow run