Skip to content

[WIP] Before finish events#5535

Draft
TonyCTHsu wants to merge 6 commits intomasterfrom
tonycthsu/before_finish_event
Draft

[WIP] Before finish events#5535
TonyCTHsu wants to merge 6 commits intomasterfrom
tonycthsu/before_finish_event

Conversation

@TonyCTHsu
Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2026-04-01 14:03:52 UTC

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Typing analysis

Note: Ignored files are excluded from the next sections.

steep:ignore comments

This PR introduces 2 steep:ignore comments, and clears 2 steep:ignore comments.

steep:ignore comments (+2-2)Introduced:
lib/datadog/tracing/span_operation.rb:328
lib/datadog/tracing/span_operation.rb:400
Cleared:
lib/datadog/tracing/span_operation.rb:325
lib/datadog/tracing/span_operation.rb:397

Untyped methods

This PR introduces 6 untyped methods and 2 partially typed methods, and clears 6 untyped methods and 2 partially typed methods.

Untyped methods (+6-6)Introduced:
sig/datadog/tracing/span_operation.rbs:145
└── def wrap_default: () { (untyped, untyped) -> untyped } -> untyped
sig/datadog/tracing/span_operation.rbs:166
└── def build_span: () -> untyped
sig/datadog/tracing/span_operation.rbs:168
└── def parent=: (untyped parent) -> untyped
sig/datadog/tracing/span_operation.rbs:170
└── def duration_marker: () -> untyped
sig/datadog/tracing/span_operation.rbs:172
└── def start_time_nano: () -> untyped
sig/datadog/tracing/span_operation.rbs:174
└── def duration_nano: () -> untyped
Cleared:
sig/datadog/tracing/span_operation.rbs:139
└── def wrap_default: () { (untyped, untyped) -> untyped } -> untyped
sig/datadog/tracing/span_operation.rbs:160
└── def build_span: () -> untyped
sig/datadog/tracing/span_operation.rbs:162
└── def parent=: (untyped parent) -> untyped
sig/datadog/tracing/span_operation.rbs:164
└── def duration_marker: () -> untyped
sig/datadog/tracing/span_operation.rbs:166
└── def start_time_nano: () -> untyped
sig/datadog/tracing/span_operation.rbs:168
└── def duration_nano: () -> untyped
Partially typed methods (+2-2)Introduced:
sig/datadog/tracing/span_operation.rbs:143
└── def initialize: (untyped default, ?logger: Core::Logger) -> void
sig/datadog/tracing/span_operation.rbs:147
└── def publish: (*untyped args) -> true
Cleared:
sig/datadog/tracing/span_operation.rbs:137
└── def initialize: (untyped default, ?logger: Core::Logger) -> void
sig/datadog/tracing/span_operation.rbs:141
└── def publish: (*untyped args) -> true

Untyped other declarations

This PR introduces 5 untyped other declarations, and clears 4 untyped other declarations. It decreases the percentage of typed other declarations from 77.73% to 77.68% (-0.05%).

Untyped other declarations (+5-4)Introduced:
sig/datadog/tracing/span_operation.rbs:114
└── attr_reader before_finish: untyped
sig/datadog/tracing/span_operation.rbs:116
└── attr_reader before_start: untyped
sig/datadog/tracing/span_operation.rbs:157
└── attr_reader events: untyped
sig/datadog/tracing/span_operation.rbs:159
└── attr_reader parent: untyped
sig/datadog/tracing/span_operation.rbs:161
└── attr_reader span: untyped
Cleared:
sig/datadog/tracing/span_operation.rbs:114
└── attr_reader before_start: untyped
sig/datadog/tracing/span_operation.rbs:151
└── attr_reader events: untyped
sig/datadog/tracing/span_operation.rbs:153
└── attr_reader parent: untyped
sig/datadog/tracing/span_operation.rbs:155
└── attr_reader span: untyped

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept on the line before the definition to remove it from the stats.

@datadog-prod-us1-6
Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 96.83%
Overall Coverage: 95.36% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 74333c7 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants