Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
BenoitZugmeyer
approved these changes
Mar 16, 2026
amortemousque
approved these changes
Mar 16, 2026
Member
There was a problem hiding this comment.
Mmh there are still some "pci" mentions in the codebase. Could you remove those?
$ git grep -F pci.
packages/core/src/domain/configuration/transportConfiguration.spec.ts: { site: 'datadoghq.com', intakeDomain: 'pci.browser-intake-datadoghq.com' },
packages/core/src/domain/intakeSites.ts:export const PCI_INTAKE_HOST_US1 = 'pci.browser-intake-datadoghq.com'
Note: the "pci" reference in packages/core/src/domain/telemetry/telemetryEvent.types.ts is fine to keep
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: b32c670 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove the deprecated
usePciIntakeoption from the Logs SDK. This option allowed customers to route logs to a PCI-compliant intake endpoint, but is being removed as part of the v7 cleanup.Changes
usePciIntakeoption fromLogsInitConfigurationinterfacebuildEndpointHost(simplifies the function signature by removingtrackTypeparameter)PCI_INTAKE_HOST_US1import fromendpointBuilder.tsusePciIntakeis set with a non-US1 siteuse_pci_intakefrom telemetry serializationTest instructions
yarn test:unitto verify existing tests passChecklist