Fix missing pyusb dependency and generally improve packaging#4
Open
rambo wants to merge 5 commits intoDamnedFacts:masterfrom
Open
Fix missing pyusb dependency and generally improve packaging#4rambo wants to merge 5 commits intoDamnedFacts:masterfrom
rambo wants to merge 5 commits intoDamnedFacts:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the modern
pyproject.tomlfor packaging. Add some really basic QA checks with pre-commit framework.Question: is 2.7 support desired (the code looks to be compatible but I have definitely not bothered to test in 2.7 and setup.py did not specify supported python versions) ? I mean 2.7 been EOLed ages ago... and we can't do type hinting etc properly there so there's a limit to how much quality can be improved if we need to maintain backwards compatibility to 2.7.