Allow customization of icecast metadata format#1395
Open
doug-hoffman wants to merge 5 commits intoDSheirer:masterfrom
Open
Allow customization of icecast metadata format#1395doug-hoffman wants to merge 5 commits intoDSheirer:masterfrom
doug-hoffman wants to merge 5 commits intoDSheirer:masterfrom
Conversation
c7a76b6 to
f4254d8
Compare
Contributor
Author
|
The new |
f4254d8 to
5cf3960
Compare
- Get current position in time - Get a segment of audio frames that exceeds the specified duration - Get the current set of frames as a bytearray
- Reduce overhead by only calling broadcastAudio() once with all frames - Pass audio time to metadata generator
- Add ability to customize formatting - Make more values available for metadata (alias list, group, site, system, and time)
5cf3960 to
dca064f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to customize the icecast metadata format at runtime in each stream's configuration. Default values are provided that are similar to the current behavior, with the addition of time and separation of tones from other
FROMidentifiers.Also includes several related improvements in other areas to support this change, including:
AudioFramesto get the current position as a time, get a segment of audio, get the current frames as a byte array.TOorFROMidentifiers contained in an identifier collection in the preferred order.The global logging level was reduced from
ALLtoDEBUGdue to the verbosity of PebbleTemplates atTRACE.User-configured metadata formats are processed through Pebble (syntax reference). This gives the user the ability to make their formatting conditional using if tags, or even modify the predefined values in some way (such as uppercasing them or providing default values).
Time formatting is handled by SimpleDateFormat (format reference).