Open
Conversation
meisterT
reviewed
Mar 1, 2026
meisterT
reviewed
Mar 1, 2026
vmcj
force-pushed
the
webstandard_small_fixes
branch
3 times, most recently
from
f7672ee to
1e271e1
Compare
nickygerritsen
approved these changes
Mar 2, 2026
meisterT
approved these changes
Mar 4, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vmcj
force-pushed
the
webstandard_small_fixes
branch
from
1e271e1 to
2030a13
Compare
This prevents pages with the same id defined multiple times. This also removes another layer of div as it seems wrongly copied.
Some pages are not reproducable in local setup, this should bring us closer to that state. It might still be the webstandard test runs destructive actions which make it not reproducable though.
The template opens the section with a <div> but closes as a <span>.
The clarification export HTML doesn't use a separate CSS file to keep it selfcontained.
vmcj
force-pushed
the
webstandard_small_fixes
branch
from
2030a13 to
55cf91d
Compare
The W3C validator doesn't like this and explicit showing it might help the jury. This is done for all input both from the judges, validator tools and the teams as defence-in-depth.
Originally we had a,role=tab with no role=tablist on the <ul> (grandparent). It seems that this still works without either of the roles as the bootstrap JS adds this during runtime.
vmcj
force-pushed
the
webstandard_small_fixes
branch
from
55cf91d to
94ce32c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those were already part of another PR but as that one needs another investigation I prefer to get those commits merged already.