Merged
Conversation
vmcj
force-pushed
the
webstandard_force_no_404
branch
from
c7796cc to
5460e17
Compare
vmcj
force-pushed
the
webstandard_force_no_404
branch
from
5460e17 to
6d2b334
Compare
vmcj
force-pushed
the
webstandard_force_no_404
branch
from
6d2b334 to
f07f1dd
Compare
Before we always generated the URL even when docs were not configured. This resulted in a 404.
As we render the links in templates we should know if the resource is available. It would detect incorrect URLs such as after switching from internal to externalids.
Wget doesn't run the javascript but follows the link used as template.
vmcj
force-pushed
the
webstandard_force_no_404
branch
from
f07f1dd to
f2510c5
Compare
nickygerritsen
approved these changes
Mar 2, 2026
Member
Author
|
Merging this now, @nickygerritsen and I discussed another improvement which I'll test a bit with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as draft first to see what should be changed.Seems to work, doing this will help us detect other issues such as when the internal ids were mapped to externalids and not all URLs were updated.