Updates and formats Building ISIS#190
Conversation
acpaquette
left a comment
There was a problem hiding this comment.
Overall looks great! A couple smaller things to address then this should be good
| @@ -18,9 +18,9 @@ find isis/src/*/apps/ -regex '.*/tsts' | sed 's:[^/]*$::' | |||
|
|
|||
| Apps that need to be refactored only have *app-name.xml* and *main.cpp*, other than the *Makefile* and other possible folders (like `assets` and `tsts`). Take a look at the [bandtrim](https://github.com/DOI-USGS/ISIS3/tree/dev/isis/src/base/apps/bandtrim) app for example. In comparison, apps that have been updated to fit the gtest suite will have *app-name.xml*, *app-name.cpp*, *app-name.h*, and *main.cpp*, like the [campt](https://github.com/DOI-USGS/ISIS3/tree/dev/isis/src/base/apps/campt) app. | |||
There was a problem hiding this comment.
Similar to the last comment, all changes look good. But bandtrim has been converted to a callable app. We might want to pick another example. An option would be to point to bandtrim before it was converted. See here:
https://github.com/DOI-USGS/ISIS3/tree/a28654ac754852f188be4c9710d001172ba459ac/isis/src/base/apps/bandtrim
|
|
||
| ```sh | ||
| # From inside your build directory (or wherever cmake was run) | ||
| ninja install |
There was a problem hiding this comment.
I would avoid running ninja/make install, without an install directory this will place the binaries into the conda environment. This applies to all of these sections that mention building with either make or ninja
Generally, it's better to just run ninja and then add $ISISROOT/bin/ to your $PATH
The full command would look something like export PATH=$ISISROOT/bin:$PATH
The Building ISIS doc seemed to be kind of outdated and contain some things that don't work anymore. I tried to streamline the first half at least, based on my recent builds.
For Example:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: