Convert AbstractShape legacy unitTest to gtest

[AstroKEW78]

Description

Converted the legacy AbstractShape unit test to a GoogleTest. The prior unitTest.cpp did not exercise AbstractShape functionality and only initialized ISIS preferences. This change removes the legacy truth based test and replaces it with an equivalent gtest smoke test.

Related Issue

N/A

How Has This Been Validated?

Built in Debug configuration and executed the new test via both runISISTests and ctest -R AbstractShape. The gtest is discoverable and passes.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation change (update to the documentation; no code change)
• Breaking change (fix or feature that would cause existing functionality to change)
• Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

• I have read and agree to abide by the Code of Conduct
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have added myself to the .zenodo.json document.
• I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

• I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

[github-actions]

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5942".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

[amystamile-usgs]

Seems like the original unit test was only created for code coverage purposes, based on this comment "Code coverage: Not Applicable. No implementation." I would say that we don't need to convert this one to a gtest since it's not doing actual testing. @Kelvinrr Is having a unit test for each object required for code coverage?

[Kelvinrr]

@amystamile-usgs It's not really a code coverage thing, I asked Kaj to just hammer away at tests, I changed instructions to sort isistestdata by size and go biggest to smallest, like we have in the past. This would have no impact on coverage really, still worht merging in order to get rid on old unittests.

[amystamile-usgs]

I say if code coverage isn't affected by removing a unit test, then there is no need to have the gtest conversion. We can probably just remove any unit tests that aren't testing anything.

[Kelvinrr]

@AstroKEW78 can you update this to just delete the old test, no need for the empty new test.

[github-actions]

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5942".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.