Convert AbstractPlate legacy unit test to gtest#5939
Merged
chkim-usgs merged 1 commit intoDOI-USGS:devfrom Jan 20, 2026
Merged
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5939". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
chkim-usgs
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the legacy AbstractPlate unit test to a GoogleTest. The legacy unitTest.cpp and associated .truth file were removed, and a new GoogleTest was added under isis/tests that exercises AbstractPlate::construct by creating a concrete test plate and validating the resulting Intercept fields. No production code behavior was changed.
Related Issue
N/A
How Has This Been Validated?
The new GoogleTest was run locally using CTest after reconfiguring CMake to remove the legacy test registration.
Validation commands:
ctest -R AbstractPlate
ctest -R AbstractPlateFixture
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: