Skip to content

Ray-to-dem intersection algorithm (continued)#5755

Merged
acpaquette merged 5 commits intoDOI-USGS:devfrom
oleg-alexandrov:dev
Apr 7, 2025
Merged

Ray-to-dem intersection algorithm (continued)#5755
acpaquette merged 5 commits intoDOI-USGS:devfrom
oleg-alexandrov:dev

Conversation

@oleg-alexandrov
Copy link
Copy Markdown
Contributor

@oleg-alexandrov oleg-alexandrov commented Apr 1, 2025 •
edited
Loading

Looks like my pull request #5408 got unintentionally nuked out.

Resubmitting with vengeance. :)

Also rebased against latest.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5755".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

4 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5755".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5755".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5755".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5755".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5755".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@Kelvinrr Kelvinrr requested a review from acpaquette April 2, 2025 16:08
oleg-alexandrov and others added 5 commits April 3, 2025 16:13
@oleg-alexandrov @acpaquette
Replace the ray-to-dem intersection algorithm with the secant method
05ffb6d 
merge

Save with debug info removed

Add code with no debug info

Wipe more debug logic

Tweak some comments

Punctuation

Hardening the logic for intersecting ray with DEM

DemShape: Let tolerance bet 1/1000 pixel, as that is more robust

Fix FunctionalTestsCamdev and FunctionalTestsCamrange

Fix FunctionalTestsCampt and FunctionalTestsCamstats

Fix some tests

Fix one more test

Must only return a DEM intersection point ahead, not behind, the camera

Update more unit tests

Update more tests

Fix more tests

Push more tests

Fix Tgo tests

Fix more tests

More fixes for TGO, LROWAC

Fix for CSV failing test

Fixes for Apollo tests and polygon test
@oleg-alexandrov @acpaquette
Rename one function. Change the tol in the inner loop for consistency.
ee1dcb7
@oleg-alexandrov @acpaquette
Propagate function rename to the header file
5c29eee
@acpaquette
Small round of test updates
d2234e4
@acpaquette
More test fixes
61b90fb
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5755".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@acpaquette acpaquette changed the title Rray-to-dem intersection algorithm (continued) Ray-to-dem intersection algorithm (continued) Apr 7, 2025
@acpaquette acpaquette merged commit a1de4e3 into DOI-USGS:dev Apr 7, 2025
2 checks passed
@acpaquette acpaquette mentioned this pull request Apr 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acpaquette acpaquette acpaquette approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleg-alexandrov @acpaquette