Skip to content

Propagate "Cube" Format#5737

Merged
Kelvinrr merged 4 commits intoDOI-USGS:devfrom
acpaquette:prop_format
Mar 5, 2025
Merged

Propagate "Cube" Format#5737
Kelvinrr merged 4 commits intoDOI-USGS:devfrom
acpaquette:prop_format

Conversation

@acpaquette
Copy link
Copy Markdown
Collaborator

@acpaquette acpaquette commented Feb 27, 2025

Description

Defaulted process classes to propagate the file format from the input cube to the output cube. Makes running something like:

ctxcal from=ingest.tiff to=ingest.cal.tiff+GTiff

into

ctxcal from=ingest.tiff to=ingest.cal.tiff

Biggest win is that users won't have to constantly remember to run each step in a process with +GTiff

Related Issue

IAA

How Has This Been Validated?

Validated from current test suite

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5737".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5737".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5737".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@chkim-usgs
Copy link
Copy Markdown
Contributor

Looks like there's one failing test: vimscal_app_test_defaultsolarcoef

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5737".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@acpaquette acpaquette added the breaking API breaking change label Mar 3, 2025
Copy link
Copy Markdown
Collaborator

@Kelvinrr Kelvinrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this so fast, just a small question in line.

commands:
$(APPNAME) from=$(INPUT)/V1515948001_1.ir.cub \
to=$(OUTPUT)/V1515948001_1.ir.cal1.cub UNITS=IOF \
to=$(OUTPUT)/V1515948001_1.ir.cal1.cub+Tile UNITS=IOF \
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this needed?

Copy link
Copy Markdown
Collaborator Author

@acpaquette acpaquette Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cube(s) used as input where Band Sequential. They were being converted to Tile automatically since it become the new default however long ago. This was one of the few app tests that needed fixing since the input was Band Sequential

@Kelvinrr Kelvinrr merged commit 1e28c61 into DOI-USGS:dev Mar 5, 2025
2 checks passed
@jrcain-usgs jrcain-usgs mentioned this pull request Feb 2, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking API breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants