chore: enable ruff rulesets related to docstrings #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstagni
force-pushed
the
enable_ruff_ruleset
branch
from
883da7c to
4896f8d
Compare
fstagni
force-pushed
the
enable_ruff_ruleset
branch
from
4896f8d to
b8fb65b
Compare
fstagni
force-pushed
the
enable_ruff_ruleset
branch
from
b8fb65b to
e22d9f0
Compare
aldbr
reviewed
Jan 22, 2026
|
|
||
| async def __aexit__(self, exc_type, exc, tb): | ||
| """This is called when exiting a route. | ||
| """Exit a route. |
Contributor
There was a problem hiding this comment.
What about?
Suggested change
| """Exit a route. | |
| """Called when exiting a route. |
|
|
||
| class FlowStatus(Enum): | ||
| """The normal flow is | ||
| """The normal flow. |
Contributor
There was a problem hiding this comment.
Just wondering why you kept "The normal flow" for FlowStatus but not for RefreshTokenStatus 😅
| "D105", | ||
| "D107", | ||
| # TODO enable this | ||
| "D401", |
Contributor
There was a problem hiding this comment.
Any reason for not applying this one at the same time?
Contributor
Author
There was a problem hiding this comment.
I vaguely remember that I simply thought that this was a big enough PR already.
Contributor
There was a problem hiding this comment.
Ok, as I already reviewed it:
- I am ok to review it again if you include
D401(I would only see the changed files since my last review) - Or if you prefer to include in another PR: can you open a github issue so that we follow it please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.