Solved compilation error for ESP8266 Node MCU v3 error for functions tha…#4
Open
byamasu-patrick wants to merge 1 commit intoDFRobot:masterfrom
Open
Solved compilation error for ESP8266 Node MCU v3 error for functions tha…#4byamasu-patrick wants to merge 1 commit intoDFRobot:masterfrom
byamasu-patrick wants to merge 1 commit intoDFRobot:masterfrom
Conversation
…t were supposed to return values but did not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t were supposed to return values but did not.
Worked on the compilation errors that I encountered due to the -Werror=return-type flag, while compiling the library to work with ESP 8266. The functions getFingerImage(uint8_t*), getQuarterFingerImage(uint8_t*), and receiveImageData(uint8_t*) are declared to return a uint8_t value, but they reach the end of the function without returning any value.
I fiedx the issue, by adding appropriate return values to these functions. Please check it out test it to see if the changes can be intergrated to save time for many people.