Feature/Filter appliance list#15
Merged
coras-company-code merged 34 commits intomainfrom Mar 10, 2026
Merged
Conversation
coras-company-code
force-pushed
the
feature/EAFEA-71-filter-appliance-list
branch
from
741a9fc to
d7d496f
Compare
coras-company-code
force-pushed
the
feature/EAFEA-71-filter-appliance-list
branch
from
32bafda to
5a5c6de
Compare
coras-company-code
changed the title
SealDebolinaCog
requested changes
Mar 6, 2026
…l see filter options
coras-company-code
force-pushed
the
feature/EAFEA-71-filter-appliance-list
branch
from
ad8e33c to
01a3fb3
Compare
SealDebolinaCog
requested changes
Mar 6, 2026
SealDebolinaCog
requested changes
Mar 9, 2026
| return typeMap[language][trimmed] || trimmed | ||
| } | ||
|
|
||
| export const countryTranslation = (data, language = 'en') => { |
Contributor
There was a problem hiding this comment.
translation function can be a single utill function, instead of 3
Contributor
Author
There was a problem hiding this comment.
Theres now one translation function - however i kept wrappers for each category to make it more readable. What you think?
// Convenience wrappers for specific categories
export const fuelTranslation = (data, language = 'en') => {
return translate('fuels', data, language)
}
export const typeTranslation = (data, language = 'en') => {
return translate('applianceTypes', data, language)
}
export const countryTranslation = (data, language = 'en') => {
return translate('countries', data, language)
}
src/server/finder/filters.js
Outdated
| } | ||
|
|
||
| const fuels = String(item.fuels) | ||
| .split(',') |
Contributor
There was a problem hiding this comment.
please fix sonar alert
|
SealDebolinaCog
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.