Open
Conversation
always send param values in no matter what the prev value is re #18921
re #18921 It seems that the issue was that presets were being loaded out of order, if we always use the async interface we maintain order also, we simply notify the host when params so we don't need to manage feedback
NOTE: using NotThreadSafe.. need to resolve this this does fix our issues with initial value AND it doesn't create an undo event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE https://app.assembla.com/spaces/max/tickets/realtime_cardwall?tickets_report_id=milestone:13092026&ticket=18921
I don't think we need this extra parameter/event interface.
A key element here is that I changed the state restore to use the async method so it happens in the correct order relative to startup events and any parameter events that came before it.
finally, now the output parameter events simply notify the host that a value has changed instead of actually setting the value and filtering out feedback (removed the filtering)