Move to JUCE 8 and bump dependencies#27
Open
sudara wants to merge 5 commits intoCrushedPixel:mainfrom
Open
Conversation
sudara
commented
Dec 15, 2025
| std::cout << indent << "Values: "; | ||
|
|
||
| if (auto valueStrings = param->getAllValueStrings(); !valueStrings.isEmpty()) { | ||
| auto valueStrings = param->getNumSteps() < 50 ? param->getAllValueStrings() : juce::StringArray(); |
Author
There was a problem hiding this comment.
JUCE now has an assertion in getAllValueStrings which fires if you call it on a float parameter... This is a mildly awkward workaround to determine whether it's "worth" printing out all values (if there are 50 or more, then it won't).
Owner
There was a problem hiding this comment.
Can you add a comment that explains this? I always like to have non-obvious code like this explained because I'm sure people will wonder this in the future when going through the code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm considering using
listParametersfor documentation / CI so got things up and running again on JUCE 8.A couple compatibility changes were needed.