🔨 lazy-init deviceId/deviceName in EndpointInfoFactory#4311
Merged
guiyanakuang merged 1 commit intomainfrom Apr 29, 2026
Merged
🔨 lazy-init deviceId/deviceName in EndpointInfoFactory#4311guiyanakuang merged 1 commit intomainfrom
guiyanakuang merged 1 commit intomainfrom
Conversation
Defer deviceUtils.getDeviceId() / getDeviceName() calls from class construction to first access. Required by the mobile project so the domestic flavor can comply with Chinese app store privacy regulations (no hardware-ID reads before the user consents to the privacy policy). No behavioral change on desktop. Refs #4310
guiyanakuang
deleted the
hammer/issue-4310-lazy-init-endpoint-info-factory
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4310
Summary
Defer
deviceUtils.getDeviceId()/getDeviceName()calls inEndpointInfoFactoryfrom class construction to first access byswitching the two properties to
by lazy.Why
The
commonMainsource set is copied into the CrossPaste mobileproject. On Android,
DeviceUtils.getDeviceId()readsSettings.Secure.ANDROID_ID, and the domestic (Chinese app store)flavor must not read hardware identifiers before the user consents to
the privacy policy. With this change, the values are only computed
when
createEndpointInfo()is actually invoked (i.e. when devicesync begins), so Phase 0 startup on mobile no longer triggers the
hardware-ID read.
Desktop impact
None observable.
EndpointInfoFactoryis only consumed once the network server isready, and
createEndpointInfo()is the only reader of these fields.getDeviceId()does not touch hardware identifiers.LazyThreadSafetyMode.SYNCHRONIZED(the default forby lazy)preserves the once-only initialization guarantee.
Test plan
./gradlew ktlintFormatclean./gradlew :app:compileKotlinDesktopsucceedsEndpointInfodeviceId/deviceNamefields are populated as before