-
Notifications
You must be signed in to change notification settings - Fork 78
Consolidate remaining backend translations #8192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5755f74 to
a439fa4
Compare
00aec35 to
2d0a466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates backend translation files for Chinese (zh), Korean (ko), and English (en) locales by merging scattered YAML files into centralized structures. The changes improve maintainability by organizing translations into fewer, more cohesive files.
Changes:
- Consolidated activerecord error messages and attributes into unified
errors.ymlandattributes.ymlfiles - Merged mailer and notifier translations into a central
mailers.ymlfile - Created
csv.ymlfor CSV export headers and values - Updated application code references to use the new translation key paths
Reviewed changes
Copilot reviewed 300 out of 343 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| config/locales/{zh,ko,en}/activerecord/errors.yml | Consolidates all activerecord error messages from multiple separate files |
| config/locales/{zh,ko,en}/activerecord/attributes.yml | Consolidates all activerecord attribute translations from multiple files |
| config/locales/{zh,ko,en}/mailers.yml | Merges course mailers, instance mailers, and notifiers into one file |
| config/locales/{zh,ko,en}/csv.yml | Centralizes all CSV export-related translations |
| config/locales/{zh,ko,en}/errors.yml | Creates unified error messages for authentication, course, and user modules |
| app/views/**/*.{slim,erb} | Updates translation key references to new consolidated paths |
| app/controllers/**/*.rb | Updates translation key references in controllers |
| app/services/**/*.rb | Updates translation key references in services |
| app/models/**/*.rb | Updates translation key references in models |
| app/helpers/**/*.rb | Updates translation key references in helpers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Consolidate scattered error translations into dedicated errors.yml files
for EN, KO, and ZH locales. This improves maintainability by organizing
all error messages in a single location per language.
Changes:
- Created config/locales/{en,ko,zh}/errors.yml with all error translations
- Updated 16 backend files to use new translation key paths with errors. prefix
- Deleted 33 component-specific translation files (11 per language)
- Fixed activerecord error structure in KO and ZH to match EN hierarchy
All translation keys now follow the pattern: errors.{domain}.{component}.{key}
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
2d0a466 to
364f97f
Compare
cysjonathan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll push to staging and check one final time against the full translation_changes_report.txt on staging before deploying.
Thanks for the massive consolidation effort!
No description provided.