feat(config): allow extra properties in config definitions#21
Merged
CorentinTh merged 1 commit intomainfrom Feb 19, 2026
Merged
feat(config): allow extra properties in config definitions#21CorentinTh merged 1 commit intomainfrom
CorentinTh merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for extra properties in config definitions by introducing a generic Extra type parameter to the configuration type system. This allows users to extend config definition elements with custom properties beyond the standard schema, env, doc, and default fields. The PR also adds .zed (Zed editor configuration) to .gitignore.
Changes:
- Added
Extrageneric parameter toConfigDefinitionElement,ConfigDefinition, andConfigDefinitionObjecttypes - Updated .gitignore to exclude Zed editor configuration folder
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/figue.types.ts | Added generic Extra parameter to allow extra properties in config definitions while maintaining backward compatibility through default type parameters |
| .gitignore | Added .zed folder to ignore list for Zed editor configuration files |
Comments suppressed due to low confidence (1)
src/figue.types.ts:25
- For clarity and maintainability, consider updating the InferSchemaType to explicitly handle the generic parameters. While the current implementation should work due to TypeScript's structural typing (since Extra is constrained to Record<string, unknown>), the type checks could be more explicit by using "ConfigDefinitionElement<any, any>" instead of relying on default type parameters. This would make the intent clearer and ensure compatibility with any Extra type.
export type InferSchemaType<T extends ConfigDefinition> = Expand<{
[P in keyof T]: T[P] extends ConfigDefinitionElement ? StandardSchemaV1.InferOutput<T[P]['schema']> : T[P] extends ConfigDefinition ? Expand<InferSchemaType<T[P]>> : never;
}>;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.