fix restarting pmls in 2D#5641
Merged
PrometheusPi merged 1 commit intoComputationalRadiationPhysics:devfrom Mar 4, 2026
Merged
fix restarting pmls in 2D#5641PrometheusPi merged 1 commit intoComputationalRadiationPhysics:devfrom
PrometheusPi merged 1 commit intoComputationalRadiationPhysics:devfrom
Conversation
franzpoeschel
approved these changes
Mar 3, 2026
Contributor
franzpoeschel
left a comment
franzpoeschel
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for the fix.
Note that this will probably conflict with #5634, which will probably remove this PML layout.
PrometheusPi
approved these changes
Mar 4, 2026
PrometheusPi
merged commit 4e5228a
into
ComputationalRadiationPhysics:dev
10 checks passed
Member
|
As this PR fixes a problem that should cease to exist with #5634 , I will delete the whole hacky (!isDomainBranch)-branch in aforementioned PR, so that code maintenance is not necessary anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1d02d93 introduced in PR #5508 breaks restarting from checkpoint in 2D simulations. This PR fixes it.