Fix Segmented control's container VisualState adjustment and arrow key focus issues #815
Merged
Arlodotexe merged 2 commits intoCommunityToolkit:mainfrom Jan 9, 2026
Merged
Conversation
…ate in vertical Orientation
Arlodotexe
approved these changes
Jan 9, 2026
Member
Arlodotexe
left a comment
There was a problem hiding this comment.
Great improvements! I don't see any logical differences between the old code and the new, except for the fixes and cleanup. Approved 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #813 and #814
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
A
SegmentedItemcontainer's VisualState will not be updated until the parentSegmentedcontrol'sOrientationproperty is updated. This results in the selected indicator showing incorrectly when items are added.Left/Right arrow keys are inverted in RTL and Up/Down keys aren't handled
What is the new behavior?
SegmentedItemcontainers are updated to match theSegmentedcontrol's VisualState when preparing the container for items.Left/Right arrow keys adjust the index properly and Up/Down keys are explicitly handled
PR Checklist
Please check if your PR fulfills the following requirements:
Other information