Merged
Conversation
Use SyntaxFactory.Literal() to produce properly escaped C# string literals for string default values in generated dependency property metadata, instead of manually wrapping the value in quotes. The previous approach did not handle special characters (eg. backslashes, quotes, newlines, tabs, null characters), resulting in invalid generated code. Fixes #788. Co-authored-by: Copilot <[email protected]>
Add a data-driven test covering string default values with various special characters including tabs, newlines, carriage returns, backslashes, quotes, null characters, and combinations thereof. This validates that the generator correctly emits properly escaped C# string literals for all these cases. Co-authored-by: Copilot <[email protected]>
Update SingleProperty_String_WithNoCaching_WithDefaultValue to take both the input literal and the expected output literal as separate parameters. Add test cases using verbatim string literals as input, verifying that the generator correctly normalizes them to regular escaped string literals in the output. This covers the @"C:\Users\Test" scenario from issue #788. Co-Authored-By: Copilot <[email protected]>
Arlodotexe
approved these changes
Apr 14, 2026
Member
Arlodotexe
left a comment
Arlodotexe
left a comment
There was a problem hiding this comment.
Reviewed and approved, easy fix and great test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #788