fix: use .csproj project references in TypeScript apphost aspire.config.json#1261
Open
aaronpowell wants to merge 11 commits intomainfrom
Open
fix: use .csproj project references in TypeScript apphost aspire.config.json#1261aaronpowell wants to merge 11 commits intomainfrom
aaronpowell wants to merge 11 commits intomainfrom
Conversation
…ig.json Replace empty/version string package references with relative .csproj paths so the Aspire CLI builds integrations from local source instead of trying to pull from NuGet. This follows the local development with project references pattern documented at aspire.dev. Co-authored-by: Copilot <[email protected]>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1261Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1261" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates TypeScript AppHost aspire.config.json files in examples/ to use local .csproj project references for CommunityToolkit packages, enabling Aspire CLI local builds instead of NuGet/package-version resolution.
Changes:
- Replaced CommunityToolkit package entries that were
""(or a version string) with relative paths to the correspondingsrc/**/**.csproj. - Kept non-CommunityToolkit Aspire package entries (e.g.,
Aspire.Hosting.*) as empty placeholders where present.
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/activemq/CommunityToolkit.Aspire.Hosting.ActiveMQ.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for ActiveMQ hosting package. |
| examples/adminer/CommunityToolkit.Aspire.Hosting.Adminer.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Adminer hosting package. |
| examples/bun/CommunityToolkit.Aspire.Hosting.Bun.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Bun hosting package. |
| examples/data-api-builder/CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Azure Data API Builder hosting package. |
| examples/dbgate/CommunityToolkit.Aspire.Hosting.DbGate.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for DbGate hosting package. |
| examples/deno/CommunityToolkit.Aspire.Hosting.Deno.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Deno hosting package. |
| examples/elasticsearch-ext/CommunityToolkit.Aspire.Hosting.Elasticsearch.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Elasticsearch Extensions hosting package. |
| examples/flagd/CommunityToolkit.Aspire.Hosting.Flagd.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Flagd hosting package. |
| examples/flyway/CommunityToolkit.Aspire.Hosting.Flyway.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Flyway hosting package. |
| examples/goff/CommunityToolkit.Aspire.Hosting.GoFeatureFlag.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for GoFeatureFlag hosting package. |
| examples/golang/CommunityToolkit.Aspire.Hosting.Golang.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Golang hosting package. |
| examples/java/CommunityToolkit.Aspire.Hosting.Java.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Java hosting package. |
| examples/javascript-ext/CommunityToolkit.Aspire.Hosting.JavaScript.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for JavaScript Extensions hosting package. |
| examples/k6/CommunityToolkit.Aspire.Hosting.k6.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for k6 hosting package. |
| examples/keycloak-postgres/CommunityToolkit.Aspire.Hosting.Keycloak.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Keycloak Extensions hosting package. |
| examples/kurrentdb/CommunityToolkit.Aspire.Hosting.KurrentDB.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for KurrentDB hosting package. |
| examples/lavinmq/CommunityToolkit.Aspire.Hosting.LavinMQ.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for LavinMQ hosting package. |
| examples/mailpit/CommunityToolkit.Aspire.Hosting.MailPit.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for MailPit hosting package. |
| examples/mcp-inspector/CommunityToolkit.Aspire.Hosting.McpInspector.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for McpInspector hosting package. |
| examples/meilisearch/CommunityToolkit.Aspire.Hosting.Meilisearch.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Meilisearch hosting package. |
| examples/minio/CommunityToolkit.Aspire.Hosting.Minio.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Minio hosting package. |
| examples/mongodb-ext/CommunityToolkit.Aspire.Hosting.MongoDB.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for MongoDB Extensions hosting package. |
| examples/mysql-ext/CommunityToolkit.Aspire.Hosting.MySql.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for MySql Extensions hosting package. |
| examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Ngrok hosting package. |
| examples/opentelemetry-collector/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for OpenTelemetryCollector hosting package. |
| examples/papercut/CommunityToolkit.Aspire.Hosting.PapercutSmtp.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for PapercutSmtp hosting package. |
| examples/postgres-ext/CommunityToolkit.Aspire.Hosting.PostgreSQL.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for PostgreSQL Extensions hosting package. |
| examples/python/CommunityToolkit.Aspire.Hosting.Python.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Python Extensions hosting package. |
| examples/redis-ext/CommunityToolkit.Aspire.Hosting.Redis.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Redis Extensions hosting package. |
| examples/rust/CommunityToolkit.Aspire.Hosting.Rust.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Rust hosting package. |
| examples/sftp/CommunityToolkit.Aspire.Hosting.Sftp.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Sftp hosting package. |
| examples/solr/CommunityToolkit.Aspire.Hosting.Solr.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Solr hosting package. |
| examples/sql-database-projects/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for SqlDatabaseProjects hosting package. |
| examples/sqlite/CommunityToolkit.Aspire.Hosting.Sqlite.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Sqlite hosting package. |
| examples/sqlserver-ext/CommunityToolkit.Aspire.Hosting.SqlServer.Extensions.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for SqlServer Extensions hosting package. |
| examples/stripe/CommunityToolkit.Aspire.Hosting.Stripe.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Stripe hosting package. |
| examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for SurrealDb hosting package. |
| examples/umami/CommunityToolkit.Aspire.Hosting.Umami.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Umami hosting package. |
| examples/zitadel/CommunityToolkit.Aspire.Hosting.Zitadel.AppHost.TypeScript/aspire.config.json | Use local .csproj reference for Zitadel hosting package. |
Add a -Secrets parameter to validate-typescript-apphost.ps1 that accepts key=value pairs. The script calls 'aspire secret set' for each pair before starting the apphost, and cleans them up via 'aspire secret delete' in the finally block. Update TypeScriptAppHostTest.Run() with an optional secrets dictionary parameter that forwards to the PowerShell script. Update the McpInspector TypeScript test to pass the required proxy-token secret parameter. Co-authored-by: Copilot <[email protected]>
tommasodotNET
approved these changes
Apr 2, 2026
…alidation The validate-typescript-apphost.ps1 script now uses dotnet msbuild -getItem:ProjectReference to discover CommunityToolkit.* project references from the integration being tested. Each discovered dependency is packed into the temp NuGet source and added to aspire.config.json alongside the main package. This fixes TypeScript apphost validation for integrations like MongoDB.Extensions, MySql.Extensions, PostgreSQL.Extensions, Redis.Extensions, and SqlServer.Extensions which depend on local packages like DbGate, Adminer, and Flyway. Co-authored-by: Copilot <[email protected]>
…grok account to be setup, which can be done locally but not for CI
…y it was defined and would cause the apphost to fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace empty/version string package references with relative .csproj paths so the Aspire CLI builds integrations from local source instead of trying to pull from NuGet. This follows the local development with project references pattern documented at aspire.dev.
Co-authored-by: Copilot [email protected]
Closes #<ISSUE_NUMBER>
PR Checklist
Other information