-
Notifications
You must be signed in to change notification settings - Fork 478
feat: Add search_aliases to node search #8223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds search_aliases to Fuse.js search keys, enabling users to find nodes by alternative names. Changes: - Add search_aliases to Fuse.js keys in nodeSearchService.ts - Add type definition for search_aliases field in nodeDefSchema.ts Depends on: comfyanonymous/ComfyUI#XXXX ## Related PRs - Backend: comfyanonymous/ComfyUI#XXXX - Docs: Comfy-Org/docs#XXXX (draft - merge after stable) Amp-Thread-ID: https://ampcode.com/threads/T-019be29a-c4bf-718e-98c2-a3c22af2c1ed Co-authored-by: Amp <[email protected]>
📝 WalkthroughWalkthroughAdds an optional Changes
Suggested reviewers
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/22/2026, 08:36:45 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 946 kB (baseline 946 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 430 kB (baseline 430 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 8 added / 8 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.8 kB (baseline 2.8 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 32.8 kB (baseline 32.8 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 3.13 MB (baseline 3.12 MB) • 🔴 +94 BStores, services, APIs, and repositories
Status: 7 added / 7 removed Utilities & Hooks — 18.1 kB (baseline 18.1 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 4 added / 4 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 6.3 MB (baseline 6.3 MB) • 🟢 -214 BBundles that do not match a named category
Status: 23 added / 23 removed |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
It's safe to merge regardless of Comfy-Org/ComfyUI#12035 being in or not. |
Myestery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
Adds `search_aliases` to Fuse.js search keys, enabling users to find nodes by alternative names. https://github.com/user-attachments/assets/6bde3e5d-29c7-4cb0-b102-e600a92c7019 ## Changes - Add `search_aliases` to Fuse.js keys in `nodeSearchService.ts` - Add type definition for `search_aliases` field in `nodeDefSchema.ts` **Depends on:** Comfy-Org/ComfyUI#12010 ## Related PRs - **Backend:** Comfy-Org/ComfyUI#12010, Comfy-Org/ComfyUI#12035 - **Adding aliases**: - Comfy-Org/ComfyUI#12016 - Comfy-Org/ComfyUI#12017 - Comfy-Org/ComfyUI#12018 - Comfy-Org/ComfyUI#12019 - **Docs:** Comfy-Org/docs#729 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8223-feat-Add-search_aliases-to-node-search-2ef6d73d365081d89bcccffb33659a88) by [Unito](https://www.unito.io) Co-authored-by: Amp <[email protected]>
Adds
search_aliasesto Fuse.js search keys, enabling users to find nodes by alternative names.2026-01-22.16-43-18_processed_20260122_164442.mp4
Changes
search_aliasesto Fuse.js keys innodeSearchService.tssearch_aliasesfield innodeDefSchema.tsDepends on: Comfy-Org/ComfyUI#12010
Related PRs
┆Issue is synchronized with this Notion page by Unito