fix: early return from slideDown/slideUp if duration is less than 1#5964
Open
Kneemund wants to merge 2 commits intoColorlibHQ:masterfrom
Open
fix: early return from slideDown/slideUp if duration is less than 1#5964Kneemund wants to merge 2 commits intoColorlibHQ:masterfrom
Kneemund wants to merge 2 commits intoColorlibHQ:masterfrom
Conversation
✅ Deploy Preview for adminlte-v4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
@Kneemund would this same fix applicable to |
Author
|
That function is never used with a duration of 0. But you're right, it could happen, so the fix should be applied to that function too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an early return to the
slideDown/slideDownfunction that skips the animation if the duration is less than (or equal to) 1.Currently, when the duration is zero, the second timeout runs BEFORE the first one (at least on Firefox), and doesn't properly clear the style attributes:
AdminLTE/src/ts/util/index.ts
Lines 96 to 112 in 5196a37
This fixes a bug in the sidebar treeview, where this function is used with a duration of zero to instantly open entries when the page loads:
AdminLTE/src/ts/treeview.ts
Line 120 in 5196a37
As an alternative fix, the duration parameter could be clamped to be greater than 1.