feat(sdk): support NuGet Central Package Management #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove implicit PackageReference for Microsoft.VSSDK.BuildTools from the SDK. This allows projects using NuGet Central Package Management (CPM) to work correctly, as CPM requires PackageReference items to not have a Version attribute when versions are centrally managed. Users must now explicitly add the PackageReference in their project: <PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.*" PrivateAssets="all" /> This is a breaking change but aligns with CPM compatibility requirements. Closes #27
Contributor
Author
|
/breaking-change The SDK no longer auto-includes the VSSDK Build Tools (this was preventing CPM from working). You must now explicitly add the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PackageReferenceforMicrosoft.VSSDK.BuildToolsfrom the SDKPackageReferenceto all e2e test projects and sample projectThis allows projects using NuGet Central Package Management (CPM) to work correctly, as CPM requires
PackageReferenceitems to not have aVersionattribute when versions are centrally managed.Breaking Change
Users must now explicitly add the
PackageReferencein their project:Test plan
Closes #27