Feature/migrate pd blocks to curriculum#1752
Feature/migrate pd blocks to curriculum#1752Beloved1310 wants to merge 18 commits intoCodeYourFuture:mainfrom
Conversation
… link for data-group
Beloved1310
requested review from
SallyMcGrath and
illicitonion
and removed request for
SallyMcGrath
illicitonion
changed the base branch from
feature/migrate-pd-blocks-to-curriculum
to
main
👷 Deploy request for cyf-piscine pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-curriculum pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-common pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-tracks pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-launch pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-itd pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-sdc pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Thanks for putting this together, it looks like a great start!
I left a few comments about formatting issues, please can you see all the places across this PR that the comments could apply, and apply them there as well?
Thanks!
| modules="JS1" | ||
| week="4" | ||
| skills="Communication" |
There was a problem hiding this comment.
These three lines don't do anything - can you remove them (and the similar lines in the other blocks?
| - What is your dream job? | ||
|
|
||
| - What professional roles will be in your team? |
There was a problem hiding this comment.
These bullet points end up double-spaced because of the empty lines between them - can you remove the empty lines? Similarly across all files
| {{<tabs name="Teamwork Project Sprint 2" >}} | ||
|
|
||
| ===[[Prep & Introduction]]=== | ||
| Prep |
There was a problem hiding this comment.
This looks like it should be a heading? Can you make it one:
| Prep | |
| ### Prep |
There are some other places that could benefit from this too
There was a problem hiding this comment.
Thank you. I omitted all the formatting of the markdown. I fixed all now
…riculum' into feature/migrate-pd-blocks-to-curriculum
|
I had to merge the updated changes. Please review and let me know if all is ok. Thank you @illicitonion |
2 participants
What does this change?
This PR migrates a block currently pulled from the CYF-PD CMS (
https://cyf-pd.netlify.app) into this repository so it can be maintained as a standard markdown block.The CMS approach adds unnecessary complexity, is no longer actively used, and makes updates harder to test and review. By moving this content into
common-content, contributors can improve it directly using existing workflows.This PR:
common-content/en/blockssrcreference inorg-cyf-itpto point to the local blockThis is part of a wider effort to migrate the remaining CYF-PD blocks used in
org-cyf-itp(6 in total).Common Content?
Common Theme?
Issue number: #1745
Org Content?
Block Type
Checklist
Who needs to know about this?
@illicitonion @cifarquhar