add --musthave-params #477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I've just found a bug in the jobqueue.py, apparently the arguments for the TextFile() creation and for the .write method were reversed. Thanks claude opus 4.5 for catching that! |
Member
|
Are you sure about TextFile? (imported from getdist, not a standard library).
…________________________________
From: Louis Legrand ***@***.***>
Sent: Tuesday, February 10, 2026 1:37:26 AM
To: CobayaSampler/cobaya ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [CobayaSampler/cobaya] add --musthave-params (PR #477)
[https://avatars.githubusercontent.com/u/50632020?s=20&v=4]louisl3grand left a comment (CobayaSampler/cobaya#477)<#477 (comment)>
I've just found a bug in the jobqueue.py, apparently the arguments for the TextFile() creation and for the .write method were reversed. Thanks claude opus 4.5 for catching that!
—
Reply to this email directly, view it on GitHub<#477 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA6GQI6NFUO73J5IS75MPP34LEY5NAVCNFSM6AAAAACURS4ZI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNZUHAZDSOBQGY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Antony,
I added an option in the cobaya grid scripts to request --musthave-params, similarly to the --musthave-data.
Cheers,
Louis