Skip to content

Conversation

@bap37
Copy link
Contributor

@bap37 bap37 commented Nov 13, 2025

Good afternoon;

I've added a couple of initial functions to start the process of integrating the new SN likelihood and data for DES-Dovekie. Starting this PR to begin the discussions on what I'm missing/what needs to be added and changed.

@bap37
Copy link
Contributor Author

bap37 commented Nov 17, 2025

Added many more necessary code changes ; will need to update the sn-data as well for some processing. the cosmo_tests for SN passes, but I'd like to just fit FLCDM cosmology with SN only to check I loaded everything in appropriately.

@cmbant
Copy link
Member

cmbant commented Nov 17, 2025

sn data v1.8 merged

@bap37
Copy link
Contributor Author

bap37 commented Nov 18, 2025

Not sure how to restart the tests. I think with sn_data updated to reflect the new hubble diagram the automatic tests should pass... if they don't, I would like to figure out why so I can fix them !

@cmbant
Copy link
Member

cmbant commented Nov 18, 2025

You need to at least push update with new sn data version?

@bap37
Copy link
Contributor Author

bap37 commented Nov 18, 2025

I think the current sn_data is fine, but I was accidentally still pointing at v1.7 in sn.py, which I've now changed to point to 1.8 (which should have the correct data).

After deleting stuff on my end, reinstalling, I found this fixed the AssertionError that the tests were seeing... fingers crossed that it did !

should be camb not classy
@cmbant cmbant merged commit f018b20 into CobayaSampler:master Nov 19, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants